Skip to content

[Quest/Malawi Core] In the app, sort the order of the tasks on the patient profile with 'double' values #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2023
Merged

[Quest/Malawi Core] In the app, sort the order of the tasks on the patient profile with 'double' values #2096

merged 2 commits into from
Feb 28, 2023

Conversation

@calmwalija
Copy link

@calmwalija calmwalija commented Feb 28, 2023 •
edited
Loading

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes https://github.com/opensrp/fhir-resources/issues/890

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@codecov
Copy link

codecov bot commented Feb 28, 2023 •
edited
Loading

Codecov Report

Merging #2096 (d221d88) into mwcore-dev (d97874b) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@               Coverage Diff                @@
##             mwcore-dev    #2096      +/-   ##
================================================
- Coverage         64.66%   64.65%   -0.01%     
+ Complexity          829      828       -1     
================================================
  Files               143      143              
  Lines              5213     5212       -1     
  Branches            862      862              
================================================
- Hits               3371     3370       -1     
  Misses             1330     1330              
  Partials            512      512
Flag Coverage Δ
engine 64.65% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/engine/data/local/register/dao/HivRegisterDao.kt 80.75% <0.00%> (ø)
...er/fhircore/engine/util/extension/TaskExtension.kt 63.15% <100.00%> (-1.85%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@calmwalija
Merge branch 'mwcore-dev' into 890-questmalawi-core-in-the-app-sort-t…
d221d88 
…he-order-of-the-tasks-on-the-patient-profile-with-double-values
@calmwalija calmwalija requested a review from sevenreup February 28, 2023 08:59
@calmwalija calmwalija self-assigned this Feb 28, 2023
@calmwalija calmwalija merged commit 2cecd04 into mwcore-dev Feb 28, 2023
@calmwalija calmwalija deleted the 890-questmalawi-core-in-the-app-sort-the-order-of-the-tasks-on-the-patient-profile-with-double-values branch February 28, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sevenreup sevenreup sevenreup approved these changes

Assignees

@calmwalija calmwalija

Labels

Malawi CORE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@calmwalija @sevenreup